refactor(frontend): add SVG schema to network schema #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
deleted the
refactor(frontend)/add-SVG-schema-to-network-schema
branch
AntonioVentilii
added a commit
that referenced
this pull request
Dec 6, 2024
# Motivation In PR #3875 , I introduced the IconSchema, considering only the environments where the local files were passed as string path. However, in production, staging, and in general in any non-local deployed environment, the element is the SVG file content. That is why we fix the schema here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As suggested in the past, we should refine the schema of network type to be more specific for the icons.