feat(frontend): add sol wallet worker #4037

loki344 · 2024-12-19T20:57:09Z

Motivation

We integrate SOL with the same worker approach as btc and ic.

Changes

Implement worker and scheduler.

Tests

Unit tests provided, same as for btc worker.

Additionally:

Bildschirmaufnahme.2024-12-19.um.21.53.30.mov

Note

During the development there were some error messages for mainnet (even though we use alchemy now).

Not reproducable at the moment. Will address this with @StefanBerger-DFINITY to check if the alchemy dashboard shows something.

…alance' into feat(frontend)/add-sol-api-for-balance

…frontend)/add-sol-worker-types

… feat(frontend)/add-sol-scheduler

…rontend)/add-sol-scheduler

…nto feat(frontend)/add-sol-worker # Conflicts: # src/frontend/src/lib/components/loaders/LoaderWallets.svelte

…l-worker # Conflicts: # src/frontend/src/sol/api/solana.api.ts # src/frontend/src/sol/types/network.ts

DenysKarmazynDFINITY · 2024-12-20T16:46:35Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+		params: LoadSolWalletParams
+	): Promise<CertifiedData<bigint | null>> => ({
+		data: await loadSolLamportsBalance({ network: params.solanaNetwork, address: params.address }),
+		certified: true


The balance you're fetching here (from 3rd party API) is not certified. Same as with Infura and ETH.

Hm ok, what does certified mean? By default the SDK uses commitment level 'finalized', so the transaction is definite. https://solana.com/docs/rpc#default-commitment

certified mean

Certified as trustworthy or provided by the Internet Computer through a certified query or update call.

Since it comes from a Web2 platform without any verification or certification of validity, it can only be trusted to some extent; hence, certified: false.

peterpeterparker

I did not review the two ...Wallets.svelte components. Can you please provide those in a separate PR with their tests.

peterpeterparker · 2024-12-23T10:52:04Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+		params: LoadSolWalletParams
+	): Promise<CertifiedData<bigint | null>> => ({
+		data: await loadSolLamportsBalance({ network: params.solanaNetwork, address: params.address }),
+		certified: true


certified mean

Certified as trustworthy or provided by the Internet Computer through a certified query or update call.

Since it comes from a Web2 platform without any verification or certification of validity, it can only be trusted to some extent; hence, certified: false.

peterpeterparker · 2024-12-23T10:56:16Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+	private loadBalance = async (
+		params: LoadSolWalletParams
+	): Promise<CertifiedData<bigint | null>> => ({
+		data: await loadSolLamportsBalance({ network: params.solanaNetwork, address: params.address }),


nitpick: if you would like to adhere to the coding style, you can destruct the params

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

peterpeterparker · 2024-12-23T10:59:11Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+		const newBalance =
+			isNullish(this.store.balance) ||
+			this.store.balance.data !== balance.data ||
+			(!this.store.balance.certified && balance.certified);


Maybe we should rather crash an error if certified become true?

Hmm, yeah sounds reasonable - The btc-wallet.scheduler.ts has the same logic ATM. I'll adjust it here and add a todo there for another PR

peterpeterparker · 2024-12-23T11:00:18Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+		this.postMessageWallet({
+			wallet: {
+				balance,
+				newTransactions: ''


It's probably better to fully omit the transactions until those are effectively loaded

You do no need to provide the certified flag here as well?

Let's keep them - They're not hurting atm and will follow shortly. They are already defined in the schema and I don't want to go back and forth.

I don't think so, the certified flag is included in the balance and set to false above.

It's hurting I think because the message are parsed with JSON on the UI side and '' is not a valid value for JSON.parse('')

Coolio

removed txns, note that this will touch an additional file

…nto feat(frontend)/add-sol-worker

…ntend)/add-sol-worker

…nto feat(frontend)/add-sol-worker

loki344 · 2025-01-06T08:42:37Z

I did not review the two ...Wallets.svelte components. Can you please provide those in a separate PR with their tests.

opened #4080

peterpeterparker

LGTM, thx

peterpeterparker · 2025-01-06T17:36:20Z

src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts

+				solanaNetwork: data.solanaNetwork
+			});
+
+			//todo implement loading transactions


nitpick: while we do not have an eslint rule for it, maybe something we can setup (?), we generally use // TODO:. Maybe easier to retrieve if you use the same pattern?

peterpeterparker · 2025-01-06T17:39:37Z

src/frontend/src/sol/services/worker.sol-wallet.services.ts

+				syncWalletError({
+					tokenId,
+					error: (data.data as PostMessageDataResponseError).error,
+					hideToast: isTestnetNetwork || isDevnetNetwork || isLocalNetwork


Can you add a TODO to review this at some point. As far as I remember neither @DenysKarmazynDFINITY nor myself were super happy with this pattern hideToast. Right Denys?

Yep, we wanted to revisit the approach at some point (e.g. by avoiding requests (or launching wallets in this case) that we know in advance are not gonna succeed, rather than making a call + failing silently).

peterpeterparker · 2025-01-06T17:44:44Z

src/frontend/src/tests/sol/schedulers/sol-wallet.scheduler.spec.ts

+describe('sol-wallet.scheduler', () => {
+	let spyLoadBalance: MockInstance;
+
+	const mockBalance = 100n;


Unrelated to this review, I just asked myself if the Solana balance was effectively a bigint, which it is. Then I had a look at loadSolLamportsBalance, which contains a comment about lamports.

Long story short, if I get it right, what do you think of creating a type type Lamports = bigint? It might be handy to retrieve those kinds of values instead of searching for bigint. Since we often have a type for values, maybe it makes sense in terms of consistency too.

Again, unrelated to this PR.

Yeah I can follow up with a PR for this.

# Note First review #4037 # Motivation Integrate the worker from #4037 in the SolLoaderWallets component to trigger the loading. # Changes Implement SolLoaderWallets. # Tests Unit tests provided --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

# Motivation As pointed out in #4037 it matches the style of the repo to use a separate type for Lamports. The Solana rpc already offers such types, so it makes sense to use it from there. # Changes Use Typing from solana RPC npm package. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

loki344 and others added 25 commits December 19, 2024 18:02

feat(frontend): add sol dependency

ed78f4b

feat(frontend): implement sol api

4b10789

feat(frontend): clarify naming

97b495b

Merge branch 'main' into feat(frontend)/add-sol-api-for-balance

3dac81d

🤖 Apply formatting changes

d5c6110

feat(frontend): rm todo

e9017b7

Merge remote-tracking branch 'origin/feat(frontend)/add-sol-api-for-b…

33c7ffd

…alance' into feat(frontend)/add-sol-api-for-balance

feat(frontend): adjust typing

49559fa

feat(frontend): adjust typing

b2a5733

feat(frontend): lint

977e23c

feat(frontend): lint

a9e1e4d

feat(frontend): lint

e4871e1

feat(frontend): lint

8655b42

Merge branch 'refs/heads/feat(frontend)/adjust-sol-typing' into feat(…

7aef276

…frontend)/add-sol-worker-types

feat(frontend): add types for worker

816f789

🤖 Apply formatting changes

936e8bb

feat(frontend): implement sol-listener

8f6c1f9

🤖 Apply formatting changes

88ebcf2

Merge branch 'refs/heads/feat(frontend)/add-sol-api-for-balance' into…

458726a

… feat(frontend)/add-sol-scheduler

feat(frontend): implement sol-wallet.scheduler.ts

1aaaf05

Merge branch 'refs/heads/feat(frontend)/add-sol-listener' into feat(f…

1dbf131

…rontend)/add-sol-scheduler

feat(frontend): implement worker for sol wallet, add unit tests

4fbc4a4

feat(frontend): implement worker for sol wallet, add unit tests

3d47454

Merge remote-tracking branch 'origin/feat(frontend)/add-sol-worker' i…

6e6fe73

…nto feat(frontend)/add-sol-worker # Conflicts: # src/frontend/src/lib/components/loaders/LoaderWallets.svelte

feat(frontend): rm import

b9a73b0

This was referenced Dec 19, 2024

feat(frontend): draft for SOL balance worker and scheduler #4030

Closed

feat(frontend): add loader for solana balances #4021

Closed

github-actions bot and others added 2 commits December 19, 2024 20:58

🤖 Apply formatting changes

b1d5d8a

Merge remote-tracking branch 'origin/main' into feat(frontend)/add-so…

d9ac699

…l-worker # Conflicts: # src/frontend/src/sol/api/solana.api.ts # src/frontend/src/sol/types/network.ts

loki344 marked this pull request as ready for review December 20, 2024 15:55

loki344 requested a review from a team as a code owner December 20, 2024 15:55

loki344 and others added 3 commits December 20, 2024 16:56

style(frontend): rm unwanted change

3e3bf34

style(frontend): fix check

360cbf0

🤖 Apply formatting changes

e41a702

DenysKarmazynDFINITY reviewed Dec 20, 2024

View reviewed changes

peterpeterparker reviewed Dec 23, 2024

View reviewed changes

loki344 and others added 12 commits January 2, 2025 16:25

add todo

cdd9042

implement MR feedback

0b3cae6

feat(frontend): rm loaders from mr

bf91bec

🤖 Apply formatting changes

93c3f2b

Merge remote-tracking branch 'origin/feat(frontend)/add-sol-worker' i…

e696cf7

…nto feat(frontend)/add-sol-worker

🤖 Apply formatting changes

e1a7793

feat(frontend): rm txns

f68d290

feat(frontend): fix tests

baeeb48

feat(frontend): fix tests

73bd616

Merge remote-tracking branch 'refs/remotes/origin/main' into feat(fro…

9125eba

…ntend)/add-sol-worker

🤖 Apply formatting changes

8bc76a6

Merge remote-tracking branch 'origin/feat(frontend)/add-sol-worker' i…

c16477a

…nto feat(frontend)/add-sol-worker

loki344 mentioned this pull request Jan 6, 2025

feat(frontend): add sol loader components #4080

Merged

loki344 requested a review from peterpeterparker January 6, 2025 12:39

peterpeterparker approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'main' into feat(frontend)/add-sol-worker

535fb6e

loki344 enabled auto-merge (squash) January 7, 2025 08:17

loki344 merged commit a3eda58 into main Jan 7, 2025
21 checks passed

loki344 deleted the feat(frontend)/add-sol-worker branch January 7, 2025 08:19

loki344 mentioned this pull request Jan 7, 2025

feat(frontend): use lamports type for SOL instead of bigint #4092

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(frontend): add sol wallet worker #4037

feat(frontend): add sol wallet worker #4037

loki344 commented Dec 19, 2024 •

edited

Loading

DenysKarmazynDFINITY Dec 20, 2024

loki344 Dec 23, 2024

peterpeterparker Dec 23, 2024

peterpeterparker left a comment

peterpeterparker Dec 23, 2024

peterpeterparker Dec 23, 2024

peterpeterparker Dec 23, 2024

loki344 Jan 2, 2025

peterpeterparker Dec 23, 2024

loki344 Jan 2, 2025

peterpeterparker Jan 6, 2025

loki344 Jan 6, 2025

loki344 commented Jan 6, 2025

peterpeterparker left a comment

peterpeterparker Jan 6, 2025

peterpeterparker Jan 6, 2025

DenysKarmazynDFINITY Jan 6, 2025

peterpeterparker Jan 6, 2025

loki344 Jan 7, 2025

feat(frontend): add sol wallet worker #4037

feat(frontend): add sol wallet worker #4037

Conversation

loki344 commented Dec 19, 2024 • edited Loading

Motivation

Changes

Tests

Note

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterpeterparker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loki344 commented Jan 6, 2025

peterpeterparker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loki344 commented Dec 19, 2024 •

edited

Loading