Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add class-name for push-analytics #1241

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Jan 24, 2024

No issue number available

*Requires dhis2/d2-analysis#148


Key features

  1. This PR adds a classname to an element which can be used by push analytics to convert a visualization to HTML.

@HendrikThePendric HendrikThePendric merged commit 7765296 into master Jan 29, 2024
4 checks passed
@HendrikThePendric HendrikThePendric deleted the feat/add-classname-for-push-analytics branch January 29, 2024 12:02
HendrikThePendric added a commit that referenced this pull request Jan 30, 2024
HendrikThePendric added a commit that referenced this pull request Jan 30, 2024
HendrikThePendric added a commit that referenced this pull request Jan 30, 2024
* fix: add class-name for push-analytics

* chore: apply consistent naming to push analytics class-names

* chore: upgrade d2-analysis to v33.3.0
@HendrikThePendric
Copy link
Contributor Author

Due to a release issue, I ended up resetting the master branch to a commit prior to this and redid these changes. See #1245 (comment) for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants