Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add class-name for push-analytics and upgrade d2-analysis #1245

Merged

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Jan 30, 2024

For future reference I will explain what happened here:

  1. I initially created feat: add class-name for push-analytics #1241, which was a feat commit resulting in a release failure because we were not allowed to release v33.3.0. See here for details about the release failure
  2. I then tried to follow the advise of the semantic release bot and reverted the commit and tried to merge a new fix commit, which I hoped would trigger the release of v33.2.59. This did not work as expected, and the semantic-release bot created a new comment in the issue it created.
  3. The current PR is attempt number 3 and as you can see below, this time I did manage to successfully trigger a release. Prior to submitting this PR I did a hard reset on the master branch to 3f95228. I then cherry-picked the changes from the other branch with --no-commit and pushed a new commit to this branch. This worked.

@HendrikThePendric HendrikThePendric merged commit cc3b582 into master Jan 30, 2024
4 checks passed
@HendrikThePendric HendrikThePendric deleted the fix/add-classname-for-push-analytics-retry branch January 30, 2024 09:48
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 33.2.59 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants