Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExposePorts Option #21

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Add ExposePorts Option #21

merged 1 commit into from
Sep 8, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Feb 13, 2023 •
edited
Loading

Add ExposePorts Option that allow to open a custom port on create container.

@mbobrovskyi mbobrovskyi mentioned this pull request Feb 20, 2023
Closed
@mbobrovskyi
Copy link
Contributor Author

@dhui Can you merge this changes ?

@mbobrovskyi mbobrovskyi mentioned this pull request May 29, 2023
Open
@maxnilz maxnilz mentioned this pull request Aug 18, 2023
Closed
@xianchaoyu xianchaoyu mentioned this pull request Aug 18, 2023
Open
@mbobrovskyi
Copy link
Contributor Author

@dhui Could you please check this pull request? Or close if not valid?

@sam-kleiner sam-kleiner mentioned this pull request May 3, 2024
Closed
@sam-kleiner
Copy link

Bumping this since its needed to fix golang-migrate/migrate#917

It looks like my issue there was the dockerfile for surrealdb does not expose ports, while most other images used in migrate tests do. This allows me to override that when creating the container.

@sam-kleiner sam-kleiner mentioned this pull request May 3, 2024
Open
@mbobrovskyi
Copy link
Contributor Author

@dhui Any updates here?

@sam-kleiner
Copy link

@dhui if you have time time would you please review this? I have confirmed it fixes the issues I was having in migrate.

@mbobrovskyi mbobrovskyi changed the title Added ExposePorts in Options Add ExposePorts in Options Sep 8, 2024
@mbobrovskyi mbobrovskyi changed the title Add ExposePorts in Options Add ExposePorts Option Sep 8, 2024
@mbobrovskyi
Copy link
Contributor Author

@dhui Please take a look 🙏. I also fixed TestRunWithExposesPorts. This changes very important for us, because we can't move on with golang-migrate/migrate#881 and golang-migrate/migrate#917.

dhui
dhui approved these changes Sep 8, 2024
View reviewed changes
Copy link
Owner

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbobrovskyi @sam-kleiner thanks for your patience!

@dhui dhui merged commit 4619817 into dhui:master Sep 8, 2024
7 checks passed
@sam-kleiner
Copy link

@mbobrovskyi @sam-kleiner thanks for your patience!

No worries I know we are all busy. Thanks for merging! Migrate is killer btw, love using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @sam-kleiner @dhui