Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

The two failures are the Python 3.14 update to release-scripts and the path syntax differences between mac and windows. I pinned the matrix test to only run on 3.12 and 3.13 for now because of incompatibility (see this convo for more info: #65 (comment)).

Using .as_posix() converts all path objects to have the format path/to/wherever. This will convert the windows syntax which is outputting path\\to\\wherever, so this bug should be fixed.

closes #69

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.46%. Comparing base (87c1f43) to head (cfda207).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   83.27%   91.46%   +8.19%     
==========================================
  Files          12        3       -9     
  Lines        1351      164    -1187     
==========================================
- Hits         1125      150     -975     
+ Misses        226       14     -212     
Files with missing lines Coverage Δ
tests/test_packsmanager.py 93.97% <100.00%> (+0.07%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. I merged this into my fork to test and everything passed.

Screenshot 2025-11-03 at 10 40 38 AM

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments. You can be the first tester o the new release script.....

project: diffpy.cmi
c_extension: false
headless: false
python_versions: "3.12, 3.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please could you remove this line. We have updated the release-scripts so this should pass tests without this now.


**Removed:**

* Removed matrix testing for Python 3.14.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't show up in the changelog. These are all just short-term developer things that will go away when we upgrade to 3.14. If no other behavior is changed in this PR (I see something being added to the tests) then this is a no-news news.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Warning! No news item is found for this PR. If this is a user-facing
change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.
For best practices, please visit
https://scikit-package.github.io/scikit-package/frequently-asked-questions.html#billinge-group-standards.

@cadenmyers13
Copy link
Contributor Author

@sbillinge I see that the new changes to the release-scripts read python version from pyproject.toml. Since we added python 3.14 support in an earlier PR i had to remove it. Im not sure why the earlier PR passed CI tests, though.

PS I removed the news item from the earlier PR as well, check for news must do a comparison with len(news.rglob(*)) or something like that, so thats why its failing despite there being a news item here.

@sbillinge sbillinge merged commit 9ce66e6 into diffpy:main Nov 3, 2025
6 of 7 checks passed
@sbillinge
Copy link
Contributor

Nice I merged. It failed news but that is ok

@cadenmyers13 cadenmyers13 deleted the windows-ci branch November 3, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: fix failing tests

2 participants