-
Notifications
You must be signed in to change notification settings - Fork 5
CI: fix matrix testing on merge #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 83.27% 91.46% +8.19%
==========================================
Files 12 3 -9
Lines 1351 164 -1187
==========================================
- Hits 1125 150 -975
+ Misses 226 14 -212
🚀 New features to boost your workflow:
|
|
@sbillinge ready for review. I merged this into my fork to test and everything passed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments. You can be the first tester o the new release script.....
| project: diffpy.cmi | ||
| c_extension: false | ||
| headless: false | ||
| python_versions: "3.12, 3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please could you remove this line. We have updated the release-scripts so this should pass tests without this now.
news/windows-ci.rst
Outdated
|
|
||
| **Removed:** | ||
|
|
||
| * Removed matrix testing for Python 3.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't show up in the changelog. These are all just short-term developer things that will go away when we upgrade to 3.14. If no other behavior is changed in this PR (I see something being added to the tests) then this is a no-news news.
|
Warning! No news item is found for this PR. If this is a user-facing |
|
@sbillinge I see that the new changes to the release-scripts read python version from pyproject.toml. Since we added python 3.14 support in an earlier PR i had to remove it. Im not sure why the earlier PR passed CI tests, though. PS I removed the news item from the earlier PR as well, check for news must do a comparison with |
|
Nice I merged. It failed news but that is ok |

The two failures are the Python 3.14 update to release-scripts and the path syntax differences between mac and windows. I pinned the matrix test to only run on 3.12 and 3.13 for now because of incompatibility (see this convo for more info: #65 (comment)).
Using
.as_posix()converts all path objects to have the formatpath/to/wherever. This will convert the windows syntax which is outputtingpath\\to\\wherever, so this bug should be fixed.closes #69