Skip to content

CI: fix matrix testing on merge #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 3, 2025
Merged

CI: fix matrix testing on merge #70

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58569a8
use as_posix to handle path differences on windows
cadenmyers13 Nov 3, 2025
034ebf7
pin python 3.12 and 3.13 in matrix testing
cadenmyers13 Nov 3, 2025
6d5f3a9
typo in python_versions
cadenmyers13 Nov 3, 2025
2cb4526
news
cadenmyers13 Nov 3, 2025
ee977af
rm python pin in both workflows
cadenmyers13 Nov 3, 2025
74bacce
fix news
cadenmyers13 Nov 3, 2025
cfda207
rm python 3.14 support and add python 3.11 support
cadenmyers13 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/matrix-and-codecov-on-merge-to-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
project: diffpy.cmi
c_extension: false
headless: false
python_versions: "3.12, 3.13"
Copy link
Contributor

@sbillinge sbillinge Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please could you remove this line. We have updated the release-scripts so this should pass tests without this now.

run: |
set -Eeuo pipefail
echo "Test cmds"
Expand Down
23 changes: 23 additions & 0 deletions news/windows-ci.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* Removed matrix testing for Python 3.14.
Copy link
Contributor

@sbillinge sbillinge Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't show up in the changelog. These are all just short-term developer things that will go away when we upgrade to 3.14. If no other behavior is changed in this PR (I see something being added to the tests) then this is a no-news news.


**Fixed:**

* <news item>

**Security:**

* <news item>
5 changes: 3 additions & 2 deletions tests/test_packsmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ def paths_and_names_match(expected, actual, root):
for (exp_name, exp_path), (act_name, act_path) in zip(expected, actual):
if exp_name != act_name:
return False
actual_rel_path = str(act_path.relative_to(root))
if actual_rel_path != exp_path:
actual_rel_path = act_path.relative_to(root).as_posix()
expected_path_norm = Path(exp_path).as_posix()
if actual_rel_path != expected_path_norm:
return False
return True

Expand Down
Loading