Network Manager View Permissions on Opportunity Details #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
approved these changes
Aug 20, 2024
hemant10yadav
approved these changes
Aug 20, 2024
calellowitz
reviewed
Aug 29, 2024
| @@ -61,13 +70,15 @@ <h1 class="mb-0">{{ object.name }}</h1> | |||
| </a> | |||
| </li> | |||
| {% endif %} | |||
| {% if not object.managed or request.org != object.organization %} | |||
There was a problem hiding this comment.
what does the second part do? why is it look for orgs that are not the opportunity's org?
There was a problem hiding this comment.
I fixed this and made the permissions a little more verbose. 77209bd
| def opportunity_user_invite(request, org_slug=None, pk=None): | ||
| opportunity = get_object_or_404(Opportunity, organization=request.org, id=pk) | ||
| form = OpportunityUserInviteForm(data=request.POST or None) | ||
| if form.is_valid(): |
There was a problem hiding this comment.
Is this part shared with the other invite view? May be nice to create a shared function
There was a problem hiding this comment.
Fixed. I have made some changes to make the forms inherit functionality. 516e6c9
calellowitz
approved these changes
Sep 12, 2024
calellowitz
approved these changes
Sep 17, 2024
Base automatically changed from
hy/network-manager-invite-and-claim
to
hy/managed-opportunity-creation
September 18, 2024 06:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Network Manager View:
Program Manager View:
