-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Manager View Permissions on Opportunity Details #380
Changes from 3 commits
b08c0d5
9aab413
3819593
77209bd
d6b301f
516e6c9
21748fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,12 +22,21 @@ <h1 class="mb-0">{{ object.name }}</h1> | |
<i class="bi bi-three-dots-vertical"></i> | ||
</button> | ||
<ul class="dropdown-menu dropdown-menu-end" aria-labelledby="opportunity_details_dropdown"> | ||
{% if object.managed and request.org == object.organization %} | ||
<li> | ||
<a class="dropdown-item" | ||
href="{% url 'opportunity:user_invite' org_slug=request.org.slug pk=opportunity.id %}"> | ||
<i class="bi bi-pencil-fill pe-2"></i> Invite Users | ||
</a> | ||
</li> | ||
{% else %} | ||
<li> | ||
<a class="dropdown-item" | ||
href="{% url 'opportunity:edit' org_slug=request.org.slug pk=opportunity.id %}"> | ||
<i class="bi bi-pencil-fill pe-2"></i> Edit | ||
</a> | ||
</li> | ||
{% endif %} | ||
{% if not object.managed %} | ||
<li> | ||
<a class="dropdown-item" | ||
|
@@ -61,13 +70,15 @@ <h1 class="mb-0">{{ object.name }}</h1> | |
</a> | ||
</li> | ||
{% endif %} | ||
{% if not object.managed or request.org != object.organization %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does the second part do? why is it look for orgs that are not the opportunity's org? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I fixed this and made the permissions a little more verbose. 77209bd |
||
<li> | ||
<a class="dropdown-item" | ||
href="{% url 'opportunity:verification_flags_config' org_slug=request.org.slug pk=opportunity.id %}"> | ||
<i class="bi bi-plus-circle-fill pe-2"></i> | ||
{% translate "Configure Verification Flags" %} | ||
</a> | ||
</li> | ||
{% endif %} | ||
<li> | ||
<a class="dropdown-item" | ||
href="{% url 'opportunity:suspended_users_list' org_slug=request.org.slug pk=opportunity.id %}"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part shared with the other invite view? May be nice to create a shared function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I have made some changes to make the forms inherit functionality. 516e6c9