Initial commit for LSSTCometActivity class in community utils.
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwamb
reviewed
Aug 4, 2023
mschwamb
reviewed
Aug 4, 2023
mschwamb
requested changes
Aug 4, 2023
There was a problem hiding this comment.
I think we have one variable hanging around that we can get rid of then it addreses dirac-institute/sorcha#501
mschwamb
reviewed
Aug 4, 2023
mschwamb
requested changes
Aug 4, 2023
mschwamb
reviewed
Aug 5, 2023
src/sorcha_community_utils/activity/lsst_comet/lsst_comet_activity.py
Outdated
Show resolved
Hide resolved
mschwamb
reviewed
Aug 5, 2023
src/sorcha_community_utils/activity/lsst_comet/lsst_comet_activity.py
Outdated
Show resolved
Hide resolved
mschwamb
reviewed
Aug 5, 2023
mschwamb
reviewed
Aug 5, 2023
mschwamb
reviewed
Aug 5, 2023
mschwamb
requested changes
Aug 5, 2023
src/sorcha_community_utils/activity/lsst_comet/lsst_comet_activity.py
Outdated
Show resolved
Hide resolved
src/sorcha_community_utils/activity/lsst_comet/lsst_comet_activity.py
Outdated
Show resolved
Hide resolved
src/sorcha_community_utils/activity/lsst_comet/lsst_comet_activity.py
Outdated
Show resolved
Hide resolved
mschwamb
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all of the code that was pulled out of sorcha that supports
LSSTCometActivity- namely the majority of the lsstcomet package, supporting tests and example notebooks.NOTE - I don't expect that the documentation notebooks will build right now - we need to wait until after the
sorchaPR (dirac-institute/sorcha#508) merges and is published to pypi before finalizing this PR.resolves #3