Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset synapse branch w/ devel #725

Closed
wants to merge 17 commits into from
Closed

reset synapse branch w/ devel #725

wants to merge 17 commits into from

Conversation

eryanRM
Copy link

@eryanRM eryanRM commented Oct 31, 2023 •
edited
Loading

Resubmitting Synapse PR to more closely align w/ Devel

Currently most failing tests are in 'test_write_dispositions'

Related Issues

David's original feedback closed PR:

  • ✅ Update w/ devel
  • ✅ Execute tests on DLT side
  • ✅ Used exact tx handling from mssql (opportunity for subclass)
  • ✅ Implemented Synapse InsertValuesLoadJob (synapse.py)
  • ✅ Added link to generate_insert_query
  • (WIP) Create shared subclass for MSSQL, Synapse

@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 9add2a4
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/654ac0cda604eb00089babbf

@eryanRM eryanRM requested a review from sh-rp October 31, 2023 12:24
eryanRM added 16 commits October 31, 2023 08:30
@eryanRM
removed print statements
2e06008
@eryanRM
temporary Synapse job insert handling and pyodbc
668ca32
@eryanRM
install odbc github action
cc870aa
@eryanRM
syncing synapse workflow w/ mssql
67b381d
@eryanRM
updating lock file and isolating synapse workflow
19b9ea1
@eryanRM
pyarrow lock file update
d796d63
@eryanRM
revert insert_job_client.py, clean redundant synapse.py
799a13d 
reviewing escape char handling
@eryanRM
revised _insert function loading data
5a058a0
@eryanRM
escape.py update, sync with local setup
1e883a0
@eryanRM
synapse escape handling '//' and synapse/sql_client.py cleanup
df89276
@eryanRM
added logging for long running merge disposition test
0e4db37
@eryanRM
escape.py cleanup -- test_merge_no_child_tables was running for > 3 h…
89f55b4 
…ours
@eryanRM
remove logging
9b42e90
@eryanRM
test on push to synapse branch
1a85df4
@eryanRM
sync synapse workflow
6afc50b
@eryanRM
synapse workflow reset
9add2a4
@eryanRM eryanRM closed this Nov 7, 2023
@eryanRM eryanRM deleted the synapse branch November 7, 2023 23:32
@eryanRM eryanRM mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-rp sh-rp Awaiting requested review from sh-rp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eryanRM