Add leading zeros to adler32 checksum to ensure 8 chars length

[amaltaro]

Fixes #9763

Status

not-tested

Description

Apparently there are cases that adler32 checksum does not result in 8 chars length word. This fix will pad it with zeros and ensure it's always a 8 chars string.

Note: for files already

Is it backward compatible (if not, which system it affects?)

yes

Related PRs

none

External dependencies / deployment changes

none

[cmsdmwmbot]

Jenkins results:

• Unit tests: failed
  • 1 tests added
• Pylint check: succeeded
  • 6 comments to review
• Pycodestyle check: succeeded
  • 2 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10249/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
  • 1 tests added
• Pylint check: succeeded
  • 6 comments to review
• Pycodestyle check: succeeded
  • 2 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10252/artifact/artifacts/PullRequestReport.html

[todor-ivanov]

Looks good to me

[amaltaro]

Just a note, if the checksum and adler32 is calculated in chunks of 2 ** 15 instead of 2 ** 12, it gives us a speedup by a factor of 4. This for a file of 1.7GB, so bigger files would provide us with even a better speed up.
I'm just not sure whether this can give us unwanted side effects...

[amaltaro]

New issue created in case we want to give further thought to this better performance in calculating the checksums:
#9811