-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Prevent focus on hidden sidebar #2265
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can it be tested?
Technically speaking, yes we can test this. I'd prefer not to implement those tests with this PR for a few reasons:
I'd like to avoid this simple fix turning into a "test all the sidebar things" rabbit hole since it is (IMHO) a pretty basic fix. |
Summary
See title and original issue (below).
Related issue, if any:
#2225
What kind of change does this PR introduce?
Feature
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: