Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscriptions that use DeserializeSeed #1

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

phil-opp
Copy link

@phil-opp phil-opp commented Jul 21, 2023

Some types need additional context for deserialization, which makes it impossible to implement DeserializeOwned. Instead, deserialization happens through the DeserializeSeed trait.

This PR adds support for creating subscriptions that use DeserializeSeed. The two main API changes are:

  • Don't require the DeserializeOwned bound to create subscriptions. Instead, require them only for the methods that absolutely need it (such as take).
  • Add a new take_seed method that deserializes using DeserializeSeed.

These changes depend on two other PRs. We might want to upstream it once they are merged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant