Docs - Small typo fixes on "Understanding iDevice Protocol Layers" doc page #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the possessive on iTunes - let the installations be itunes installations instead of owned by multiple itunes - change includes to include to fit the pluralization
Swap 'delve as to' with 'delve into' which fits better and is the same form as the other uses of delve in this doc.
Reword a clunky sentence by removing an out of place 'both' and trying to clarify what is meant. This might not be the right answer -- created a sentence that means you can access both lockdown and other RemoteXPC services. If this wasn't the desired meaning maybe it should be "all the other lockdown and RemoteXPC services" instead. Also it's possible 'lockdown' should be 'lockdownd' instead.
The change result is still a very long sentence and could be broken down some more but it as at least a bit shorter and slightly more organized.
|
Thanks for the very detailed PR! :) |
|
Thanks for the repo! Happy to help in this small way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for this awesome library. I was reading the docs and learned a lot from the detailed write up here; thanks for putting the time into it!
I noticed a couple small typos in that doc and wanted to create a PR with them separated out as commits if you want to take them. None of them are significant; this is just minor cleanup that I noticed while reading the doc and wanted to contribute a tiny bit back. Each change is in its own commit, occasionally with light notes. Feel free to take any or none of them - like I said they are inconsequential (and sometimes just my opinion) typos/nits in documentation text so no harm is being done if you just close this PR instead.
Thanks again!