Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix breadcrumb errors #29650

Merged
merged 6 commits into from
Aug 20, 2024
Merged

chore: fix breadcrumb errors #29650

merged 6 commits into from
Aug 20, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Aug 19, 2024 •
edited by github-actions bot
Loading

Parent Issue

#29648

Proposed Changes

  • Fix problem with breadcrumbs styles and PrimeNG v17
  • Fix problem with storybook and alias signals

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Screenshots

Original Updated
Screenshot 2024-08-19 at 9 30 30 PM Screenshot 2024-08-19 at 9 30 36 PM
Screenshot 2024-08-19 at 9 32 37 PM Screenshot 2024-08-19 at 9 32 46 PM
Screenshot 2024-08-19 at 9 33 23 PM Screenshot 2024-08-19 at 9 33 32 PM
localhost_64737_dotAdmin localhost_4200_dotAdmin_
localhost_64737_dotAdmin (1) localhost_4200_dotAdmin_ (1)
localhost_64737_dotAdmin (2) localhost_4200_dotAdmin_ (2)

This PR fixes: #29648

@nicobytes nicobytes changed the title chore: fix errors chore: fix breadcrumb errors Aug 19, 2024
@nicobytes nicobytes mentioned this pull request Aug 19, 2024
Merged
9 tasks
@nicobytes nicobytes linked an issue Aug 19, 2024 that may be closed by this pull request
PrimeNG v17: Fix Breadrumb issues #29648
Closed
@nicobytes nicobytes marked this pull request as ready for review August 20, 2024 01:47
@nicobytes nicobytes merged commit eb5b46f into epic-primeng-upgrade Aug 20, 2024
1 check passed
@nicobytes nicobytes deleted the 29648-fix-breadrumb branch August 20, 2024 14:10
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@nicobytes @oidacra
@spbolton @victoralfaro-dotcms @hmoreras
Epic about PrimeNG Upgrade (#29614)
f58464f 
### Parent Issue
#29058


### Objective

This is a PR to collect small PRs to upgrade from PrimeNG v15 to v17.

### PRs associated

- [x] #29057
- [x] #29624
- [x] #29562
- [x] #29650
- [x] #29658
- [x] #29674
- [x] #29704
- [x] #29706
- [x] #29737

---------

Co-authored-by: Arcadio Quintero <[email protected]>
Co-authored-by: spbolton <[email protected]>
Co-authored-by: Victor Alfaro <[email protected]>
Co-authored-by: Humberto Morera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinogiardino valentinogiardino valentinogiardino approved these changes

@rjvelazco rjvelazco rjvelazco approved these changes

@hmoreras hmoreras hmoreras approved these changes

@oidacra oidacra Awaiting requested review from oidacra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrimeNG v17: Fix Breadrumb issues
4 participants
@nicobytes @hmoreras @rjvelazco @valentinogiardino