Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODATA Security & expand #12150

Closed
wants to merge 16 commits into from
Closed

ODATA Security & expand #12150

wants to merge 16 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Apr 24, 2019 •
edited
Loading

@Rick-Anderson Rick-Anderson changed the title ODATA Security DRAFT: ODATA Security Apr 25, 2019
@Rick-Anderson Rick-Anderson marked this pull request as ready for review April 25, 2019 01:52
@Rick-Anderson Rick-Anderson added Security-PU Must be reviewed by product unit security. PU and removed Security-PU Must be reviewed by product unit security. labels Apr 25, 2019
@Rick-Anderson
Copy link
Contributor Author

@FIVIL please review. See Public review URL Might get stale

From my testing all that works without the EDM except the EDM stuff at the end of the article. Is that correct?

@Rick-Anderson Rick-Anderson changed the title DRAFT: ODATA Security ODATA Security Apr 25, 2019
@FIVIL
Copy link
Contributor

FIVIL commented Apr 25, 2019

@Rick-Anderson
Yes, I also tested them, all of them work just fine (paging and ordering on indexed columns tested in production under load)
however, we didn't mention Expand() which enables querying related data and therefore it causes SQL joins and can be super demanding. I wanted to add Expand() related stuff to my second sets of articles but if you are creating security-related docs I assume we should mention it.

@Rick-Anderson
Copy link
Contributor Author

@FIVIL push a commit to this branch with Expand

@FIVIL
Copy link
Contributor

FIVIL commented Apr 25, 2019

@Rick-Anderson Sure thing. (I just need a bit time to finalize my work on them)

@Rick-Anderson
Copy link
Contributor Author

@FIVIL No hurry. We all greatly appreciate your valuable contributions.

@FIVIL
Copy link
Contributor

FIVIL commented Apr 28, 2019

@Rick-Anderson
i created a new PR for $expand samples, i submitted PR to this branch 2/ODATA/security/ra not the master branch.
#12191

@FIVIL @Rick-Anderson
Odata-expand (#12206)
e20d0e9 
* adding project files

* Upgrate to 2.2 and file ending

* improving grades
@FIVIL FIVIL mentioned this pull request May 4, 2019
Merged
@FIVIL
Copy link
Contributor

FIVIL commented May 4, 2019 •
edited
Loading

@Rick-Anderson
I finished expand documentation.
#12283

@FIVIL @Rick-Anderson
Odata-expand2 (#12283)
6fc3894 
* adding markdown file

* controller

* Customizing related data

* expand depth

* security
@Rick-Anderson Rick-Anderson changed the title ODATA Security WIP: ODATA Security May 6, 2019
@Rick-Anderson Rick-Anderson removed PU Security-PU Must be reviewed by product unit security. labels May 6, 2019
@Rick-Anderson Rick-Anderson changed the title WIP: ODATA Security ODATA Security & expand May 7, 2019
@Rick-Anderson Rick-Anderson added PU Security-PU Must be reviewed by product unit security. labels May 7, 2019
@Rick-Anderson
Copy link
Contributor Author

@hassanhabib please review

@hassanhabib
Copy link
Contributor

@hassanhabib please review

@Rick-Anderson looks good to me - great stuff! thank you for doing this!

@Rick-Anderson
Copy link
Contributor Author

@FIVIL please review my changes to expand

@FIVIL
Copy link
Contributor

FIVIL commented May 8, 2019

@Rick-Anderson
They are fine with me.

@Rick-Anderson Rick-Anderson reopened this May 14, 2019
@Rick-Anderson
Copy link
Contributor Author

@danroth27 please recommend a reviewer for ODATA.

This was referenced Oct 16, 2019
Closed
Open
@Rick-Anderson
Copy link
Contributor Author

@serpent5 How do I update these sample to 3.0 with endpoint routing? Note the sample/doc will not got in this repo, it's going to MicrosoftDocs/OData-docs#69

@Rick-Anderson
Copy link
Contributor Author

What would be nice is having Startup2.2.cs and a 3.0 version. Maybe use #if 2_2 in Main.

@serpent5
Copy link
Contributor

serpent5 commented Oct 31, 2019 •
edited
Loading

How do I update these sample to 3.0 with endpoint routing?

It doesn't look like it's possible right now. See OData/WebApi#1748 (comment) and the related thread.

@Rick-Anderson
Copy link
Contributor Author

@serpent5 thanks! I'll move the 2.2 samples over.

@Rick-Anderson Rick-Anderson removed PU Security-PU Must be reviewed by product unit security. labels Nov 8, 2019
@Rick-Anderson Rick-Anderson mentioned this pull request Nov 14, 2019
Merged
@Rick-Anderson
Copy link
Contributor Author

Moved to MicrosoftDocs/OData-docs#74

@Rick-Anderson Rick-Anderson deleted the 2/ODATA/security/ra branch January 4, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FIVIL FIVIL FIVIL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OData Expand Create an ODATA security doc
4 participants
@Rick-Anderson @FIVIL @hassanhabib @serpent5