Skip to content

Conversation

jameshkramer
Copy link
Contributor

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also fixes a few article files from previous commits.

Please merge #17846 before merging this.

cc: @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 16, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jameshkramer

I had a couple comments to consider, along with a question for Maira

Billing,
}

private AddressUse addressType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is expanding scope, but is this a good time to remove the private fields and change the later properties to auto-implemented properties?

@mairaw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is my call. It certainly is beyond scope, because it is well beyond the attitude of "get the articles merged and go from there". That does necessarily argue against it - we have already gone beyond scope, I think, which is not necessarily bad.

I might or might not be the right person to make such changes. I don't really understand what you propose, but if it only requires knowledge of C# I would be fine. If it depends on knowing LINQ, I might not be the best person.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the task focused on bringing the articles over. And then you can make the improvements later @BillWagner?

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Apr 26, 2020
@mairaw
Copy link
Contributor

mairaw commented Apr 26, 2020

@jameshkramer please resolve the new merge conflicts

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments to be addressed before merging.

@mairaw mairaw merged commit 9f446d1 into dotnet:linq-to-xml Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants