Add an Fedora 41 amd64 image and fix other Fedora Dockerfiles to use consistent formatting #1214
Conversation
MichaelSimons
commented
Oct 16, 2024
MichaelSimons
commented
- Add support for Fedora 41
- Note: dnf was upgraded to dnf 5 which affects the way new package feeds are registered
- Fixed Fedora 39 and 40 Dockerfiles to:
- use consistent && formatting
- remove the checked in microsoft.asc file and download it instead like all of the other distro Dockerfiles do
src/fedora/41/amd64/Dockerfile
Outdated
| && dnf clean all | ||
|
|
||
| # Add MS package repo. | ||
| RUN dnf5 config-manager addrepo \ |
There was a problem hiding this comment.
@omajid - I would appreciate your eyes on this. Is this the best way to register package.microsoft.com with dnf 5?
There was a problem hiding this comment.
The docs say that the replacement for dnf config-manager --add-repo is dnf5 config-manager addrepo. So this does seem to be the correct 1-to-1 port of the old dnf command.
There was a problem hiding this comment.
I see that there's a repo file already at https://packages.microsoft.com/fedora/41/prod/config.repo. Can/should we download and use that directly instead of duplicating it here? (This approach would work with dnf as well).
There was a problem hiding this comment.
I missed that PMC had a config.repo file. I will use that. Thanks.
There was a problem hiding this comment.
I made this change in 344a3af
