-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Fedora 41 amd64 image and fix other Fedora Dockerfiles to use consistent formatting #1214
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| FROM library/fedora:41 | ||
|
|
||
| # Install the base toolchain we need to build anything (clang, cmake, make and the like) | ||
| # this does not include libraries that we need to compile different projects, we'd like | ||
| # them in a different layer. | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| clang \ | ||
| cmake \ | ||
| dnf-plugins-core \ | ||
| findutils \ | ||
| gdb \ | ||
| glibc-langpack-en \ | ||
| lldb-devel \ | ||
| llvm-devel \ | ||
| make \ | ||
| pigz \ | ||
| python \ | ||
| which \ | ||
| && dnf clean all | ||
|
|
||
| # Add MS package repo. | ||
| RUN dnf5 config-manager addrepo \ | ||
| --set=name=Microsoft \ | ||
| --set=baseurl=https://packages.microsoft.com/fedora/41/prod/ \ | ||
| --set=enabled=1 \ | ||
| --set=gpgcheck=1 \ | ||
| --set=gpgkey=https://packages.microsoft.com/keys/microsoft.asc \ | ||
| && dnf makecache | ||
|
|
||
| # Install tools used by build automation. | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| azure-cli \ | ||
| git \ | ||
| jq \ | ||
| tar \ | ||
| procps \ | ||
| zip \ | ||
| && dnf clean all | ||
|
|
||
| # Install the latest non-preview powershell release. | ||
| RUN LATEST_TAG=$(curl -L https://api.github.com/repos/powershell/powershell/releases/latest | jq -r '.tag_name') \ | ||
| && curl -L https://github.com/PowerShell/PowerShell/releases/download/$LATEST_TAG/powershell-${LATEST_TAG#*v}-linux-x64.tar.gz -o /tmp/powershell.tar.gz \ | ||
| && mkdir -p /opt/microsoft/powershell \ | ||
| && tar zxf /tmp/powershell.tar.gz -C /opt/microsoft/powershell \ | ||
| && chmod +x /opt/microsoft/powershell/pwsh \ | ||
| && ln -s /opt/microsoft/powershell/pwsh /usr/bin/pwsh \ | ||
| && rm -f /tmp/powershell.tar.gz | ||
|
|
||
| # Dependencies of CoreCLR, Mono and CoreFX. | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| autoconf \ | ||
| automake \ | ||
| brotli-devel \ | ||
| glibc-locale-source \ | ||
| iputils \ | ||
| jq \ | ||
| krb5-devel \ | ||
| libcurl-devel \ | ||
| libgdiplus \ | ||
| libicu-devel \ | ||
| libomp-devel \ | ||
| libtool \ | ||
| libunwind-devel \ | ||
| libuuid-devel \ | ||
| lttng-ust-devel \ | ||
| openssl-devel \ | ||
| uuid-devel \ | ||
| zlib-devel \ | ||
| && dnf clean all | ||
|
|
||
| # Dependencies for VMR/source-build tests | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| elfutils \ | ||
| file \ | ||
| && dnf clean all | ||
|
|
||
| # Install ICU package to support globalization | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| icu \ | ||
| && dnf clean all | ||
|
|
||
| # Dependencies for Aspnetcore | ||
| RUN cd ~ \ | ||
| && curl -sL https://rpm.nodesource.com/setup_20.x | ||
| RUN dnf --setopt=install_weak_deps=False install -y \ | ||
| nodejs \ | ||
| && dnf clean all | ||
| ENV NO_UPDATE_NOTIFIER=true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omajid - I would appreciate your eyes on this. Is this the best way to register package.microsoft.com with dnf 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs say that the replacement for
dnf config-manager --add-repoisdnf5 config-manager addrepo. So this does seem to be the correct 1-to-1 port of the old dnf command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there's a repo file already at https://packages.microsoft.com/fedora/41/prod/config.repo. Can/should we download and use that directly instead of duplicating it here? (This approach would work with
dnfas well).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that PMC had a config.repo file. I will use that. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change in 344a3af