Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pip for MicroBuild install task validation #1304

Closed
wants to merge 1 commit into from

Conversation

ellahathaway
Copy link
Member

Needed for dotnet/arcade-validation#4698.

From test build:

Error: Unable to locate executable file: 'pip'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

MicroBuild install task uses pip to install the ESRP Az CLI extension. As such, we should include pip as a dependency in the image.

@MichaelSimons
Copy link
Member

This is orthogonal... Does arcade-validation have a tracking issue to migrate to AzureLinux 3.0? It would be good for them to upgrade.

@ellahathaway
Copy link
Member Author

ellahathaway commented Dec 17, 2024

This is orthogonal... Does arcade-validation have a tracking issue to migrate to AzureLinux 3.0? It would be good for them to upgrade.

Edit - nvm the response I got was about VMs, not container images. The updated response that I got was that it was legacy. I'm going to migrate them to azure linux 3.0 and close this PR.

@ellahathaway ellahathaway marked this pull request as ready for review December 17, 2024 18:04
@ellahathaway ellahathaway requested review from a team as code owners December 17, 2024 18:04
Comment on lines +20 to +21
# Provides functionality for MicroBuild install task
python3-pip \
Copy link
Contributor

@lbussell lbussell Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly install the python3 package here as well?

While it is installed in the base image, it is a dependency of MicroBuild, so it may be good to list it here.

Copy link
Member Author

@ellahathaway ellahathaway Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. It gets installed with pip though in this case:

docker run --rm 4841e5ea63ba0dffda5636f3ce67cda96aa2b703a2d916e47a43e568d508787e python3 -V
Python 3.9.19

Granted it's not the latest version.

Copy link
Contributor

@lbussell lbussell Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction on my part, doesn't look like python3 comes in the base image for either CBL Mariner 2.0 or Azure Linux 3.0.

@jkoritzinsky
Copy link
Member

Why is arcade-validation using the fpm image? That image is only meant to be used for building rpms with the old tooling.

@ellahathaway
Copy link
Member Author

Why is arcade-validation using the fpm image? That image is only meant to be used for building rpms with the old tooling.

No idea - the answer I received from them is that it is legacy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants