Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pip for MicroBuild install task validation #1304

Closed
wants to merge 1 commit into from
Closed

Install pip for MicroBuild install task validation #1304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cbl-mariner/2.0/fpm/amd64/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,7 @@ RUN tdnf install -y \
# Provides functionality for AzureCLI AzDO task
powershell \
azure-cli \
# Provides functionality for MicroBuild install task
python3-pip \
Comment on lines +20 to +21
Copy link
Contributor

@lbussell lbussell Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly install the python3 package here as well?

While it is installed in the base image, it is a dependency of MicroBuild, so it may be good to list it here.

Copy link
Member Author

@ellahathaway ellahathaway Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. It gets installed with pip though in this case:

docker run --rm 4841e5ea63ba0dffda5636f3ce67cda96aa2b703a2d916e47a43e568d508787e python3 -V
Python 3.9.19

Granted it's not the latest version.

Copy link
Contributor

@lbussell lbussell Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction on my part, doesn't look like python3 comes in the base image for either CBL Mariner 2.0 or Azure Linux 3.0.

&& tdnf clean all \
&& gem install fpm
Loading