[iOS] Fix DatePicker to consistently display 4-digit years #31464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/ios
area-controls-datetimepicker
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an iOS DatePicker issue where 4-digit years would inconsistently display as 2-digit years after user interaction. The fix applies a regex replacement to convert 2-digit year patterns to 4-digit patterns in the date format string when using default or short date formats.
Key changes:
- Modified date formatting logic to ensure consistent 4-digit year display
- Added comprehensive test coverage for various date format scenarios
- Created UI tests to validate the fix through user interaction scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Core/src/Platform/iOS/DatePickerExtensions.cs |
Implements regex-based fix to convert 2-digit to 4-digit year patterns in date format strings |
src/Core/tests/DeviceTests/Handlers/DatePicker/DatePickerHandlerTests.iOS.cs |
Adds extensive device tests covering various date format scenarios and edge cases |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31117.cs |
Creates comprehensive UI tests to validate 4-digit year consistency through user interactions |
src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml |
Provides XAML UI for automated testing with proper AutomationId attributes |
src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml.cs |
Implements code-behind for the test UI page with date manipulation functionality |
rmarinho
previously approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Member
|
/rebase |
github-actions
bot
force-pushed
the
fix-31167-II
branch
from
524b67c to
445d234
Compare
Contributor
|
DatePicker should not show 2-digit year pattern Assert.That(datePickerText, Does.Not.Contain("/24")) Expected: not String containing "/24" But was: "12/24/2024" the code looks correct, but the test looks wrong |
| var currentText = App.WaitForElement("MyDatePicker").GetText(); | ||
| Assert.That(currentText, Does.Contain("2024"), | ||
| $"After interaction #{i + 1}, should still show 4-digit year"); | ||
| Assert.That(currentText, Does.Not.Contain("/24"), |
Contributor
There was a problem hiding this comment.
Suggested change
| Assert.That(currentText, Does.Not.Contain("/24"), | |
| Assert.That(currentText, Does.Contain("2024"), |
github-project-automation
bot
moved this from Approved
to Changes Requested
in MAUI SDK Ongoing
Member
|
/rebase |
github-actions
bot
force-pushed
the
fix-31167-II
branch
from
ab168d0 to
f299fc4
Compare
Member
|
@copilot please create a new pr taking over this pr |
7 tasks
Contributor
Member
github-project-automation
bot
moved this from Changes Requested
to Done
in MAUI SDK Ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The issue occurred in DatePickerExtensions.cs in the UpdateDate method. When using the default date format (null, empty, or "d"), the code uses NSDateFormatterStyle.Short which defaults to 2-digit year patterns on iOS. After user interaction triggers date updates, this causes inconsistent year display.
This PR apply changes to apply a regex replacement to convert 2-digit years to 4-digit years. The regex safely avoids modifying already-correct 4-digit year patterns.
Added comprehensive test coverage with device and ui tests.
Issues Fixed
Fixes #31167