Avoid extra JTF collection/factory #9623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LanguageServiceHost` uses its own JTF collection and factory to track its work. This class derives from `OnceInitializedOnceDisposedAsync`, which also has its own collection and factory. @lifengl recently noticed this while investigating a hang and suggested that we reuse the base class's objects to reduce allocations and potentially even help avoid deadlocks.
drewnoakes
added
Feature-Language-Service
lifengl
approved these changes
Dec 17, 2024
This value can be shared across all projects throughout the lifetime of VS. Making it static reduces allocations and causes the factory logic to run once, rather than per-project.
This avoids the overhead associated with the instance's re-entrancy prevention.
haileymck
approved these changes
Dec 18, 2024
melytc
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LanguageServiceHostuses its own JTF collection and factory to track its work.This class derives from
OnceInitializedOnceDisposedAsync, which also has its own collection and factory.@lifengl recently noticed this while investigating a hang and suggested that we reuse the base class's objects to reduce allocations and potentially even help avoid deadlocks.
Microsoft Reviewers: Open in CodeFlow