Avoid double disposal of terminal logger #49969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to release/10.0.1xx-preview7 |
|
Started backporting to release/10.0.1xx-preview7: https://github.com/dotnet/sdk/actions/runs/16571305334 |
7 tasks
baronfel
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression that caused an "Unhandled exception: The CancellationTokenSource has been disposed." error when running dotnet run file.cs with the terminal logger. The fix prevents double disposal of the console logger by nulling the reference after disposal and adding a null check before calling Shutdown().
Key changes:
- Adds null assignment to avoid double disposal
- Adds null-conditional operator to prevent calling Shutdown() on disposed logger
MiYanni
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #49841 -
dotnet run file.csresults in "Unhandled exception: The CancellationTokenSource has been disposed." It only appears when using the terminal logger, hence no tests catch it (and I don't think it can be tested, see dotnet/msbuild#12237).