Skip to content

Commit

Permalink
Merge pull request ceph#868 from ceph/wip-6896
Browse files Browse the repository at this point in the history
osd: Remove bogus assert(active == acting.size())

Reviewed-by: Samuel Just <[email protected]>
  • Loading branch information
David Zafman committed Nov 25, 2013
2 parents 5ccc2ec + 66f51f8 commit d6c8830
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/osd/PG.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1204,9 +1204,6 @@ void PG::activate(ObjectStore::Transaction& t,
if (is_primary()) {
// start up replicas

// count replicas that are not backfilling
unsigned active = 1;

assert(actingbackfill.size() > 0);
for (unsigned i=1; i<actingbackfill.size(); i++) {
int peer = actingbackfill[i];
Expand Down Expand Up @@ -1269,9 +1266,6 @@ void PG::activate(ObjectStore::Transaction& t,
if (needs_past_intervals)
m->past_intervals = past_intervals;

if (pi.last_backfill == hobject_t::get_max())
active++;

// update local version of peer's missing list!
if (m && pi.last_backfill != hobject_t()) {
for (list<pg_log_entry_t>::iterator p = m->log.log.begin();
Expand Down Expand Up @@ -1299,8 +1293,6 @@ void PG::activate(ObjectStore::Transaction& t,
}
}

assert(active == acting.size());

// degraded?
if (get_osdmap()->get_pg_size(info.pgid) > acting.size())
state_set(PG_STATE_DEGRADED);
Expand Down

0 comments on commit d6c8830

Please sign in to comment.