-
Notifications
You must be signed in to change notification settings - Fork 43
Elasticsearch 7 rest client #58
base: master
Are you sure you want to change the base?
Elasticsearch 7 rest client #58
Conversation
@purplesword Thanks for your contribution! Could you please resolve the conflicts with the master branch and remove Gradle from the PR? We're not planning to change the build system from Maven to Gradle. |
|
||
@JsonProperty | ||
@NotNull | ||
private Map<String, String> settings = Collections.emptyMap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite few settings which might be interesting for the Low Level REST client.
Could we add them here?
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/java-rest-low-usage-initialization.html
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/java-rest-low-config.html
Also adding the possibility to add the Sniffer would be nice:
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/_usage.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a bunch more.. Not sure if did it properly.. Tests will be added soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more tests now the coverage is higher and 100% on health checks.
Could you comment more about what do you think is necessary to be covered in configuration?
I added most of them listed in the documentation (but feel a bit hard to write test unless using testcontainer). Also I sort of feel it's a bit too complicate, maybe it's better to cover some simple common configs and then let sophisticated users do what they want with the ManagedClient(client,sniffer)
constructor with their own client and sniffer..
No description provided.