This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch 7 rest client #58
base: master
Are you sure you want to change the base?
Elasticsearch 7 rest client #58
Changes from 20 commits
ae1a25c
8557d8c
50a3077
e9e1162
358d966
884ec00
2c119f9
c063419
bab9fd9
5ebc6e7
fc889bf
2e96a0c
26bb7ff
223bc45
22d01c7
29dffca
9afc1ea
cfda4b3
f5498d8
01b8fda
43bbef2
691fe3f
aa473f3
4ce4c2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite few settings which might be interesting for the Low Level REST client.
Could we add them here?
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/java-rest-low-usage-initialization.html
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/java-rest-low-config.html
Also adding the possibility to add the Sniffer would be nice:
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.1/_usage.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a bunch more.. Not sure if did it properly.. Tests will be added soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more tests now the coverage is higher and 100% on health checks.
Could you comment more about what do you think is necessary to be covered in configuration?
I added most of them listed in the documentation (but feel a bit hard to write test unless using testcontainer). Also I sort of feel it's a bit too complicate, maybe it's better to cover some simple common configs and then let sophisticated users do what they want with the
ManagedClient(client,sniffer)
constructor with their own client and sniffer..This file was deleted.