Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for error and report the error on the result of quackScanState->preparedStatement->Execute() #38

Merged
merged 4 commits into from
May 29, 2024

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented May 29, 2024

While working on the UnsupportedPostgresType I came across an infinite hang in the client, traced it down to not checking for an execution error, this fixed it

@Tishj Tishj requested a review from mkaruza May 29, 2024 13:23
@mkaruza
Copy link
Collaborator

mkaruza commented May 29, 2024

Is there reproduction steps which can be added for regression ?

@Tishj
Copy link
Collaborator Author

Tishj commented May 29, 2024

I'll add a test, likely creating a table with varchar and putting abc into it, then running select a::INTEGER from tbl already causes this

Having a bit of trouble with postgres right now, server is broken and doesn't want to shut down
After I get it resolved I'll create the test

@mkaruza mkaruza merged commit 530f502 into main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants