Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate main strings in French #1477

Conversation

olivierperez
Copy link

Task/Issue URL: #559

Description

Steps to test this PR

FR translation

  1. Switch your device to French
  2. Navigate through the app (mostly around Bookmarks and Widgets)

UI changes

I cannot build the app, I face this message

Execution failed for task ':app:generateJsonModelInternalDebug'.
E:\progs\android\Duckduckgo\app\CMakeLists.txt : C/C++ internalDebug|arm64-v8a : CMake Error at E:\progs\android\Duckduckgo\app\CMakeLists.txt:13 (add_library):
Cannot find source file:

And no file listed below it 🤷

If you could help me on that build I would add screenshots 👍

@cmonfortep
Copy link
Contributor

Thanks for the contribution @olivierperez. However, we are currently using an external service to request translations and we updated the contribution guidelines to reflect that. See our comment in the issue you linked on the description #559 (comment).

"We only accept translations tweaks that fix actual issues (typos, grammatical errors) and won't accept minor changes that are only focused on tweaking the wording."

The strings you translated are in our "untranslated" string files because we still need to send those strings to our translation team. We will accept contributions for fixes once they have been already translated.

@cmonfortep cmonfortep closed this Oct 11, 2021
@olivierperez
Copy link
Author

Whoops, my bad, I didn't see this information.
However, if you want to use theses translations into the external service you use, feel free to do so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants