Sync bookmarks - notify user when sync paused #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
cmonfortep
force-pushed
the
feature/cristian/sync/feature_limit_ui
branch
3 times, most recently
from
0551ba6 to
3250c81
Compare
cmonfortep
force-pushed
the
feature/cristian/sync/feature_limit_ui
branch
2 times, most recently
from
5561575 to
987b615
Compare
cmonfortep
force-pushed
the
feature/cristian/sync/feature_limit_ui
branch
from
987b615 to
978b0ee
Compare
malmstein
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
nice work @cmonfortep, works as expected. left a few comments
.../saved-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/sync/SaveSiteRateLimitView.kt
Outdated
Show resolved
Hide resolved
...mpl/src/main/java/com/duckduckgo/savedsites/impl/sync/SaveSitesRateLimitSyncMessagePlugin.kt
Outdated
Show resolved
Hide resolved
saved-sites/saved-sites-impl/src/main/res/layout/view_save_site_rate_limit_warning.xml
Outdated
Show resolved
Hide resolved
saved-sites/saved-sites-impl/src/main/res/layout/view_save_site_rate_limit_warning.xml
Outdated
Show resolved
Hide resolved
cmonfortep
force-pushed
the
feature/cristian/sync/feature_limit_ui
branch
from
978b0ee to
785950e
Compare
4 tasks
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/488551667048375/1206017382069031/f ### Description Notify user when sync is paused due collection limit or payload too large. ### Steps to test this PR _Feature 1_ - [x] Fresh install - [x] Go to sync settings and create an account - [x] Ensure you don't see any warning or notification about sync paused - [x] Add a Login - [x] Patch should work, no rate limit - [x] Go to the code base, `RealSyncEngine:L186` replace Success logic with: ``` is Success -> { persisterPlugins.getPlugins().forEach { it.onError(SyncErrorResponse(changes.type, COLLECTION_LIMIT_REACHED)) } //persistChanges(result.data, conflictResolution) } ``` - [x] install app with changes - [x] run the app - [x] Add a Login to trigger a Patch - [x] You should receive a system notification - [x] Go to sync settings, ensure warning is present - [x] Clicking on the warning should take you to Logins Screen - [x] Undo the change you applied in `RealSyncEngine:L186` - [x] install app again - [x] on open, will trigger a patch again - [x] Notification and sync setting warning should be gone - [x] Ensure no warning is present ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1206017382069028/f
Description
Notify user when sync is paused due collection limit or payload too large.
Steps to test this PR
Feature 1
RealSyncEngine:L186replace Success logic with:RealSyncEngine:L186UI changes