Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notify me view to sync settings #3945

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Nov 30, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1206051770773058/f

Description

Shows Notify me view for Android 13+ users if notifications are disabled

Steps to test this PR

Feature 1

  • fresh install app on Android 13+ device
  • do not accept notifications
  • Create a sync account
  • ensure notify me view appears on sync settings

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏩ ADS

@cmonfortep cmonfortep merged commit 45ab343 into feature/cristian/sync/credentials_limit_ui Dec 1, 2023
7 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/sync/notification_permission branch December 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants