Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Improve PR review notifications #5409

Merged

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Dec 18, 2024

Task/Issue URL: https://app.asana.com/0/0/1208984904365490/f

Description

Use remote workflow to post comments in an Asana task based on the review state.
Depends on duckduckgo/native-github-asana-sync#6 being merged and relased

Steps to test this PR

See https://github.com/duckduckgo/Android/actions/runs/12400985000/job/34619364179?pr=5274

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein marked this pull request as ready for review December 19, 2024 11:54
@malmstein malmstein requested a review from nalcalag as a code owner December 19, 2024 11:54
@mikescamell mikescamell self-assigned this Dec 19, 2024
Copy link
Contributor

@mikescamell mikescamell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 👨‍🍳 💋! Nice work!

@malmstein malmstein merged commit ad5e0d9 into develop Dec 19, 2024
2 checks passed
@malmstein malmstein deleted the feature/david/12-18-gha_improve_pr_review_notifications branch December 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants