Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Improve PR review notifications #5409

Merged
merged 3 commits into from
Dec 19, 2024
Merged

GHA: Improve PR review notifications #5409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f76fd96
GHA: Improve PR review notifications
malmstein Dec 18, 2024
703c12e
remove old workflow
malmstein Dec 19, 2024
44287ad
revert formatting
malmstein Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .github/workflows/action-pr-approved.yaml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/pr-review-notifications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: Pull Request Reviewed -> Asana Sync
name: Pull Request Reviewed -> Sync With Asana

on:
pull_request_review:
types: [submitted]

jobs:
pr-reviewed:
name: Update Asana task -> PR reviewed
uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@david/improve-pr-notifications
name: Add PR reviewed comment
uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@v1.4
with:
trigger-phrase: "Task/Issue URL:"
secrets:
Expand Down
Loading