Improved IPC support #536
Improved IPC support #536
Conversation
| // This is actually an improved way to send messages. | ||
| // Please avoid adding new messages to this enum, and instead | ||
| // add them to `ExtensionRequest` | ||
| case request(_ request: ExtensionRequest) |
There was a problem hiding this comment.
Comment has it... ExtensionRequest is meant to replace ExtensionMessage.
| case sendTestNotification | ||
| } | ||
|
|
||
| public enum ExtensionRequest: Codable { |
There was a problem hiding this comment.
The advantage of using this is two folded:
- Much simpler: adding a case is enough to be able to receive it in the extension, there's no need to add code to encode the data.
- Less likely to cause trouble: because the app and extension use this enum, adding a new case will present an error if the case handling is missing in either side.
| import Combine | ||
| import Foundation | ||
|
|
||
| extension UserDefaults { |
There was a problem hiding this comment.
It's a bit annoying to have to add these, but this is how we can use UserDefaults as an IPC mechanism through its inter-process KVO notifications. Even if the user edits a value from the command line, we'll get notified of the change.
| <dict> | ||
| <key>_XCCurrentVersionName</key> | ||
| <string>HTTPSUpgrade 3.xcdatamodel</string> | ||
| </dict> | ||
| <dict/> |
There was a problem hiding this comment.
Interesting, any reason why this changed?
| @@ -17,25 +17,13 @@ | |||
| // | |||
|
|
|||
| import Foundation | |||
|
|
|||
| /* | |||
| protocol NetworkProtectionSelectedServerStore: AnyObject { | |||
There was a problem hiding this comment.
One note is that we'll have to add something like this back to handle geoswitching, I believe
diegoreymendez
deleted the
diego/feature/change-netp-vpn-ownership-prototype
branch
Task/Issue URL: https://app.asana.com/0/72649045549333/1205529334042574/f BSK PR: duckduckgo/BrowserServicesKit#536 iOS PR: duckduckgo/iOS#2101 ## Description Moves the VPN ownership to the menu agent
Task/Issue URL: https://app.asana.com/0/0/1205738275545703/f BSK PR: duckduckgo/BrowserServicesKit#536 macOS PR: duckduckgo/macos-browser#1690 ## Description Integrates the latest changes from BSK.
| private func selectedServerFromRawValue(_ rawValue: String?) -> TunnelSettings.SelectedServer { | ||
| guard let selectedEndpoint = networkProtectionSettingSelectedServerRawValue else { | ||
| return .automatic | ||
| } | ||
|
|
||
| return .endpoint(selectedEndpoint) | ||
| } |
There was a problem hiding this comment.
Is this intentional to use networkProtectionSettingSelectedServerRawValue directly here instead of rawValue? I see the same thing with registrationKeyValidityFromRawValue(_:) @diegoreymendez
There was a problem hiding this comment.
Nopes... I think I missed this one, but didn't realize since it's unlikely to fail. Good catch!
* main: Fix syncing empty favorites folders (#546) Alert user about abnormal app conditions (#539) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#543) NetP iOS notifications settings (#541) Secure vault app group support (#532) Update autofill to 9.0.0 (#537) linting (#542) feat(dashboard): updating feedback form (#533) Improved IPC support (#536) bump C-S-S for duckplayer on big sur (#538) (#540) Append build number to metricKit crash version (#534)
Task/Issue URL: https://app.asana.com/0/0/1205738275545702/f
iOS PR: duckduckgo/iOS#2101
macOS PR: duckduckgo/macos-browser#1690
What kind of version bump will this require?: Minor
Description
Offers improved IPC support in BSK.
How to test
See iOS and macOS PRs for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template