Address VPN ship review problems #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
approved these changes
Mar 22, 2024
| @@ -194,7 +194,6 @@ public final class VPNSettings { | |||
| defaults.resetNetworkProtectionSettingNotifyStatusChanges() | |||
| defaults.resetNetworkProtectionSettingRegistrationKeyValidity() | |||
| defaults.resetNetworkProtectionSettingSelectedServer() | |||
| defaults.resetNetworkProtectionSettingSelectedEnvironment() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206899355242110/f
iOS PR: duckduckgo/iOS#2623
macOS PR: duckduckgo/macos-browser#2477
What kind of version bump will this require?: Patch
Description:
This PR prevents the app from resetting the environment when uninstalling the VPN.
The environment is a debug-only setting, and uninstalling the browser is common to do when testing internally, so we should keep it persisted.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template