Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returns empty certificate array when no certificate #750

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Mar 26, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1206880509171835/f
iOS PR:
macOS PR: duckduckgo/macos-browser#2511
What kind of version bump will this require?: Major/Minor/Patch

Description: In case of SSL error will give the user the option of bypass the error and visit the site anyway. See Figma → and https://app.asana.com/0/72649045549333/1206755044584061

Optional:

Tech Design URL: https://app.asana.com/0/0/1206862686877685/f
CC:

Description: On macOS In case of SSL error will give the user the option of bypass the error and visit the site anyway. See Figma → and https://app.asana.com/0/72649045549333/1206755044584061

Steps to test this PR:

  1. See platforms description

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ayoy ayoy marked this pull request as ready for review April 10, 2024 08:59
@SabrinaTardio SabrinaTardio merged commit b0749d2 into main Apr 12, 2024
7 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/ssl-error branch April 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants