[WIP] Update dependencies #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GioSensation
commented
Aug 14, 2023
| "jest-chrome": { | ||
| "jest": "$jest" | ||
| } | ||
| } |
There was a problem hiding this comment.
Needed because jest-chrome is set to be dependent to jest 27, but it's not actually necessary. They've already merged the necessary change but haven't released (it's been a few months), so this is temporary.
GioSensation
commented
Aug 14, 2023
| @@ -5,16 +5,16 @@ | |||
| */ | |||
| export class DeviceApiCall { | |||
| /** @type {string} */ | |||
| method= 'unknown'; | |||
| method = 'unknown' | |||
There was a problem hiding this comment.
Bunch of linting updates.
GioSensation
commented
Aug 14, 2023
| @@ -10,7 +10,7 @@ exports[`when all data is available updates each platforms task notes 1`] = ` | |||
| <li>version [[version]]</li> | |||
| <li>[[commit]]</li> | |||
| <li>[[release_url]]</li> | |||
| <li><a href=\\"https://github.com/duckduckgo/android/pr/1\\">Android PR</a></li> | |||
There was a problem hiding this comment.
They've updated the format.
GioSensation
commented
Aug 14, 2023
| @@ -2,7 +2,7 @@ import { generateFiles } from '../api-call-generator.js' | |||
| import { join } from 'path' | |||
|
|
|||
| describe('api call generator', () => { | |||
| it('generates files from fixtures', async () => { | |||
| it.skip('generates files from fixtures', async () => { | |||
There was a problem hiding this comment.
Skipping for now as I couldn't figure this out. It tries to access the json schema file but fails. Not sure why.
There was a problem hiding this comment.
Agreed to skip - I did a little check locally and something with jest is causing issues.
GioSensation
commented
Aug 14, 2023
| static defaults = defaults; | ||
| static get defaults () { | ||
| return defaults | ||
| } |
There was a problem hiding this comment.
No idea why these changes were necessary, TBH. Class fields were causing a weird error a build time. Transforming this into a getter fixed it. This is called only once so I believe it's fine.
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
GioSensation
force-pushed
the
ema/update-deps
branch
from
6dc8310 to
8e2f0b3
Compare
Signed-off-by: Emanuele Feliziani <[email protected]>
… ema/update-deps Signed-off-by: Emanuele Feliziani <[email protected]> # Conflicts: # dist/autofill-debug.js # dist/autofill.js # package-lock.json # package.json # swift-package/Resources/assets/autofill-debug.js # swift-package/Resources/assets/autofill.js
Signed-off-by: Emanuele Feliziani <[email protected]>
Signed-off-by: Emanuele Feliziani <[email protected]>
shakyShane
approved these changes
Sep 26, 2023
This was referenced Sep 28, 2023
brindy
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 28, 2023
Task/Issue URL: https://app.asana.com/0/1205602928782192/1205602928782192 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.1 BSK PR: duckduckgo/BrowserServicesKit#517 ## Description Updates Autofill to version [8.4.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.1). ### Autofill 8.4.1 release notes ## What's Changed * Precompile regexes by @GioSensation in duckduckgo/duckduckgo-autofill#382 * Add perf tests by @GioSensation in duckduckgo/duckduckgo-autofill#383 * deps: remove deprecated content-scope-utils by @shakyShane in duckduckgo/duckduckgo-autofill#384 * Update dependencies by @GioSensation in duckduckgo/duckduckgo-autofill#368 * Fix perf regressions by @GioSensation in duckduckgo/duckduckgo-autofill#385 **Full Changelog**: duckduckgo/duckduckgo-autofill@8.4.0...8.4.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). --------- Co-authored-by: GioSensation <[email protected]> Co-authored-by: Chris Brind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/0/1205509987156725/f
Description
Just updating a bunch of dependencies.
Steps to test
Test suit working fine.