-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update dependencies #368
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ebbe1da
Update deps
GioSensation 323cfda
Update snapshots format
GioSensation 074a4f6
Update validators
GioSensation 0216187
Update jest-environment-jsdom
GioSensation fad39dc
Fix weird error in apple.password.js
GioSensation 13f4aeb
Fix linting issues
GioSensation 2262c8d
Skip test
GioSensation 6914e22
Update content-scope-utils
GioSensation b22a858
Do not typecheck dependency
GioSensation e1dcf20
Add it back
GioSensation 8e2f0b3
Compile after merge
GioSensation 448b763
Update even more dependencies
GioSensation bc2c387
Merge branch 'main' of github.com:duckduckgo/duckduckgo-autofill into…
GioSensation 725c33d
Fix linting
GioSensation 47d7923
Recompile after merge
GioSensation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,16 +5,16 @@ | |
*/ | ||
export class DeviceApiCall { | ||
/** @type {string} */ | ||
method= 'unknown'; | ||
method = 'unknown' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bunch of linting updates. |
||
/** | ||
* An optional 'id' - used to indicate if a request requires a response. | ||
* @type {string|null} | ||
*/ | ||
id = null; | ||
id = null | ||
/** @type {Params | null | undefined} */ | ||
paramsValidator = null; | ||
paramsValidator = null | ||
/** @type {Result | null | undefined} */ | ||
resultValidator = null; | ||
resultValidator = null | ||
/** @type {import("zod").infer<Params>} */ | ||
params | ||
/** | ||
|
@@ -24,15 +24,15 @@ export class DeviceApiCall { | |
* @deprecated this is here to aid migration, should be removed ASAP | ||
* @type {boolean} | ||
*/ | ||
throwOnResultKeysMissing = true; | ||
throwOnResultKeysMissing = true | ||
/** | ||
* New messages should be in a particular format, eg: { success: T }, | ||
* but you can set this to false if you want to access the result as-is, | ||
* without any unwrapping logic | ||
* @deprecated this is here to aid migration, should be removed ASAP | ||
* @type {boolean} | ||
*/ | ||
unwrapResult = true; | ||
unwrapResult = true | ||
/** | ||
* @param {import("zod").infer<Params>} data | ||
*/ | ||
|
@@ -142,7 +142,7 @@ export class DeviceApiCallError extends Error {} | |
*/ | ||
export class SchemaValidationError extends Error { | ||
/** @type {import("zod").ZodIssue[]} */ | ||
validationErrors = []; | ||
validationErrors = [] | ||
|
||
/** | ||
* @param {import("zod").ZodIssue[]} errors | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed because
jest-chrome
is set to be dependent to jest 27, but it's not actually necessary. They've already merged the necessary change but haven't released (it's been a few months), so this is temporary.