Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force trigger config reload when patching config in tests #2143

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Force trigger config reload when patching config in tests #2143

merged 3 commits into from
Jul 28, 2023

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Jul 27, 2023 •
edited
Loading

  • In some integration tests we patch the config object stored in tdsStorage directly.
  • For MV3, we might not catch this config change unless the config updated event is fired.
  • This PR triggers this event manually after patching, so MV3 rules will be correctly generated.
  • This should fix some intemittent test failures, where config patches weren't picked up.

@sammacbeth sammacbeth changed the title WIP: Fix flakey tests Force trigger config reload when patching config in tests Jul 27, 2023
@sammacbeth sammacbeth marked this pull request as ready for review July 27, 2023 09:13
@sammacbeth sammacbeth requested a review from kzar July 27, 2023 09:13
@sammacbeth sammacbeth merged commit 5d4a64f into main Jul 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzar kzar kzar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @kzar