Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force trigger config reload when patching config in tests #2143

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Force trigger config reload when patching config in tests #2143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79fd97e
Reduce test timeout
sammacbeth Jul 27, 2023
4ac47cc
Trigger tds callbacks after patching config
sammacbeth Jul 27, 2023
4e76d2a
Tune back timeout
sammacbeth Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration-test/helpers/testConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export async function loadTestConfig (bgPage, testConfigFilename) {
globalThis.configBackup[pathString] = target[lastPathPart]
target[lastPathPart] = pageTestConfig[pathString]
}
return globalThis.dbg.tds._internalOnListUpdate('config', globalThis.dbg.tds.config)
}, {
pageTestConfig: testConfig,
parsePathString: parsePath.toString()
Expand Down
2 changes: 1 addition & 1 deletion integration-test/storage-blocking.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ test.describe('Storage blocking Tests', () => {
await backgroundWait.forAllConfiguration(backgroundPage)
await loadTestConfig(backgroundPage, 'storage-blocking.json')
await loadTestTds(backgroundPage, 'mock-tds.json')
// await routeFromLocalhost(page)
await routeFromLocalhost(page)

// reset allowlists
await backgroundPage.evaluate(async (domain) => {
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { defineConfig, devices } from '@playwright/test'
export default defineConfig({
testDir: './integration-test',
/* Maximum time one test can run for. */
timeout: 60 * 1000,
timeout: 30 * 1000,
expect: {
/**
* Maximum time expect() should wait for the condition to be met.
Expand Down
Loading