Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Sync environment to production #2009

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Sep 14, 2023

Task/Issue URL: https://app.asana.com/0/0/1205489036222324/f

Description:
This patch switches default server environment for Sync to production and adds environment switcher
to the Debug menu.

Steps to test this PR:

  1. Run the app and identify as internal user
  2. Enable Sync, verify that requests are being sent to the production endpoint (sync.duckduckgo.com)
  3. Go to Debug menu -> Sync Info -> Environment
  4. Verify that it shows that Production is active and it offers you to switch to Development
  5. Switch to Development
  6. Verify that you have been logged out of Sync
  7. Enable Sync, verify that requests are being sent to the development endpoint (dev-sync-use.duckduckgo.com)
  8. Go to Debug menu -> Sync -> Environment
  9. Verify that it shows that Development is active and it offers you to switch to Production
  10. Restart the app, verify that you're still on Development environment.
  11. Switch back to Production and verify that you've been logged out.

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Sep 14, 2023
@ayoy ayoy marked this pull request as ready for review September 14, 2023 07:32
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit f4597a5 into develop Sep 14, 2023
@ayoy ayoy deleted the dominik/sync-env-switcher branch September 14, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants