-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftLint build plugin #2233
Merged
Merged
SwiftLint build plugin #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
force-pushed
the
alex/swiftlint-plugin
branch
from
December 6, 2023 18:13
952fd1c
to
99f6906
Compare
samsymons
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this change looks good. It looks like the cache key calculation logic on CI can't handle the updated Package.resolved format, but once that's resolved (and the BSK change is merged) this is good to merge.
2 tasks
samsymons
added a commit
that referenced
this pull request
Dec 21, 2023
* main: (35 commits) Add Sync feature flags (#2279) Add Sync Success Rate pixel (#2277) add test 5 and fix test 4 (#2276) Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274) Send WG invalid state reason (#2275) Typo Fix: "SwiftLintPlugin" must be enabled before it can be used Release 7.102.0 (#2273) Add search retention pixel for NetP (#2267) Run sync tests in matrix (#2263) SwiftLint build plugin (#2233) Update VPN active user check and debug options (#2269) Update Autofill Logins copy (#2246) Remove the reconnect/disconnect logic from the connection tester (#2272) Remove the Fastlane notes file temporarily (#2270) remove QR code from save recovery PDF view (#2271) Show dev environment indicator in Sync Settings (#2265) Release 7.101.0.1 (#2262) Sync Flow Error Handling (#2264) Fix fingerprinting UI tests (#2252) ...
samsymons
added a commit
that referenced
this pull request
Dec 22, 2023
# By Sam Symons (13) and others # Via Bartek Waresiak (2) and others * main: (69 commits) Custom config URL (#2278) Fix internal user toggling (#2282) Display warning icon in Sync Settings cell when data syncing is disabled (#2281) Add Sync feature flags (#2279) Add Sync Success Rate pixel (#2277) add test 5 and fix test 4 (#2276) Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274) Send WG invalid state reason (#2275) Typo Fix: "SwiftLintPlugin" must be enabled before it can be used Release 7.102.0 (#2273) Add search retention pixel for NetP (#2267) Run sync tests in matrix (#2263) SwiftLint build plugin (#2233) Update VPN active user check and debug options (#2269) Update Autofill Logins copy (#2246) Remove the reconnect/disconnect logic from the connection tester (#2272) Remove the Fastlane notes file temporarily (#2270) remove QR code from save recovery PDF view (#2271) Show dev environment indicator in Sync Settings (#2265) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205944207430351/1204377796839424/f
BSK PR: duckduckgo/BrowserServicesKit#393
Description:
Steps to test this PR: