Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint build plugin #2233

Merged
merged 18 commits into from
Dec 18, 2023
Merged

SwiftLint build plugin #2233

merged 18 commits into from
Dec 18, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Dec 6, 2023

Task/Issue URL: https://app.asana.com/0/1205944207430351/1204377796839424/f
BSK PR: duckduckgo/BrowserServicesKit#393

Description:

  • Replaced swiftlint usage with build plugin

Steps to test this PR:

  1. validate no linter issues locally
  2. validate no linter issues on CI, but linter still works

@mallexxx mallexxx requested a review from samsymons December 6, 2023 16:33
@mallexxx mallexxx force-pushed the alex/swiftlint-plugin branch from 952fd1c to 99f6906 Compare December 6, 2023 18:13
@mallexxx mallexxx changed the title Alex/swiftlint plugin SwiftLint build plugin Dec 7, 2023
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this change looks good. It looks like the cache key calculation logic on CI can't handle the updated Package.resolved format, but once that's resolved (and the BSK change is merged) this is good to merge.

@mallexxx mallexxx merged commit 5f8ab87 into main Dec 18, 2023
10 checks passed
@mallexxx mallexxx deleted the alex/swiftlint-plugin branch December 18, 2023 08:08
samsymons added a commit that referenced this pull request Dec 21, 2023
* main: (35 commits)
  Add Sync feature flags (#2279)
  Add Sync Success Rate pixel  (#2277)
  add test 5 and fix test 4 (#2276)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274)
  Send WG invalid state reason (#2275)
  Typo
  Fix: "SwiftLintPlugin" must be enabled before it can be used
  Release 7.102.0 (#2273)
  Add search retention pixel for NetP (#2267)
  Run sync tests in matrix (#2263)
  SwiftLint build plugin (#2233)
  Update VPN active user check and debug options (#2269)
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
  Show dev environment indicator in Sync Settings (#2265)
  Release 7.101.0.1 (#2262)
  Sync Flow Error Handling (#2264)
  Fix fingerprinting UI tests (#2252)
  ...
samsymons added a commit that referenced this pull request Dec 22, 2023
# By Sam Symons (13) and others
# Via Bartek Waresiak (2) and others
* main: (69 commits)
  Custom config URL (#2278)
  Fix internal user toggling (#2282)
  Display warning icon in Sync Settings cell when data syncing is disabled (#2281)
  Add Sync feature flags (#2279)
  Add Sync Success Rate pixel  (#2277)
  add test 5 and fix test 4 (#2276)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274)
  Send WG invalid state reason (#2275)
  Typo
  Fix: "SwiftLintPlugin" must be enabled before it can be used
  Release 7.102.0 (#2273)
  Add search retention pixel for NetP (#2267)
  Run sync tests in matrix (#2263)
  SwiftLint build plugin (#2233)
  Update VPN active user check and debug options (#2269)
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
  Show dev environment indicator in Sync Settings (#2265)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants