Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint build plugin #2233

Merged
merged 18 commits into from
Dec 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build
mallexxx committed Dec 6, 2023
commit 99f69062486a695cbf01f2f40c8b976a489472fa
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -9212,7 +9212,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = revision;
revision = 0ec3fc0c05c39b63037880413a4940e839b87a70;
revision = 26a0aea93c56552803144da3d57f8a06a9df777b;
};
};
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"repositoryURL": "https://github.com/DuckDuckGo/BrowserServicesKit",
"state": {
"branch": null,
"revision": "0ec3fc0c05c39b63037880413a4940e839b87a70",
"revision": "26a0aea93c56552803144da3d57f8a06a9df777b",
"version": null
}
},

Unchanged files with check annotations Beta

errorEvents: preMigrationErrorHandling
)
bookmarksDatabase.loadStore { [weak self] context, error in

Check warning on line 192 in DuckDuckGo/AppDelegate.swift

GitHub Actions / Unit Tests

variable 'self' was written to, but never read

Check warning on line 192 in DuckDuckGo/AppDelegate.swift

GitHub Actions / Unit Tests

variable 'self' was written to, but never read
guard let context = context else {
if let error = error {
Pixel.fire(pixel: .bookmarksCouldNotLoadDatabase,
private func authenticate() {
hideUnlockInstructions()
authenticator.authenticate { (success, _) in

Check warning on line 64 in DuckDuckGo/AuthenticationViewController.swift

GitHub Actions / Unit Tests

'authenticate(reply:)' is deprecated: Use async/await

Check warning on line 64 in DuckDuckGo/AuthenticationViewController.swift

GitHub Actions / Unit Tests

'authenticate(reply:)' is deprecated: Use async/await
if success {
self.onAuthenticationSucceeded()
} else {
func testBrokenSiteReporting() throws {
let testJSON = data.fromJsonFile(Resource.tests)
let testString = String(data: testJSON, encoding: .utf8)

Check warning on line 47 in DuckDuckGoTests/BrokenSiteReportingTests.swift

GitHub Actions / Unit Tests

initialization of immutable value 'testString' was never used; consider replacing with assignment to '_' or removing it
let testData = try JSONDecoder().decode(BrokenSiteReportingTestData.self, from: testJSON)
referenceTests = testData.reportURL.tests.filter {