Fixes a crash in the VPN #2513
Merged
Fixes a crash in the VPN #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2024
samsymons
approved these changes
Feb 28, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 28, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206703155649003/f iOS PR: duckduckgo/iOS#2513 macOS PR: duckduckgo/macos-browser#2282 What kind of version bump will this require?: Major/Minor/Patch ## Description Fixes a crash in the VPN. ## Testing See the platform-specific PRs for testing instructions.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Feb 28, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206703155649003/f Tech Design URL: CC: iOS PR: duckduckgo/iOS#2513 BSK PR: duckduckgo/BrowserServicesKit#685 ## Description Fixes a crash in the VPN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206703155649003/f
Tech Design URL:
CC:
macOS PR: duckduckgo/macos-browser#2282
BSK PR: duckduckgo/BrowserServicesKit#685
Description
Fixes a crash in the VPN.
Testing
As the crash isn't easy to repro, just connect and disconnect a few times and check all is good.
Internal references:
Software Engineering Expectations
Technical Design Template