Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash in the VPN #2282

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 28, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206703155649003/f
Tech Design URL:
CC:

iOS PR: duckduckgo/iOS#2513
BSK PR: duckduckgo/BrowserServicesKit#685

Description

Fixes a crash in the VPN.

Testing

As the crash isn't easy to repro, just connect and disconnect a few times and check all is good.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez changed the base branch from main to release/1.77.0 February 28, 2024 15:12
@diegoreymendez diegoreymendez marked this pull request as ready for review February 28, 2024 15:14
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Feb 28, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206703155649003/f
iOS PR: duckduckgo/iOS#2513
macOS PR: duckduckgo/macos-browser#2282
What kind of version bump will this require?: Major/Minor/Patch

## Description
 
Fixes a crash in the VPN.

## Testing

See the platform-specific PRs for testing instructions.
@diegoreymendez diegoreymendez merged commit 19b85fb into release/1.77.0 Feb 28, 2024
17 checks passed
@diegoreymendez diegoreymendez deleted the diego/fix-tunnel-crasher branch February 28, 2024 15:59
diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants