BSK update for Autofill Script performance improvements #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
github-actions
bot
added
the
bot: not in app board
aataraxiaa
approved these changes
Mar 22, 2024
…perf-improvements # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
removed
the
bot: not in app board
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 25, 2024
Task/Issue URL: https://app.asana.com/0/414709148257752/1206900948756760/f iOS PR: duckduckgo/iOS#2625 macOS PR: duckduckgo/macos-browser#2481 What kind of version bump will this require?: Patch Description: Greatly reduces the amount of data passed into the autofill script to improve performance and resolve occasional out of memory crashes
samsymons
added a commit
that referenced
this pull request
Mar 25, 2024
# By Anh Do (1) and others # Via GitHub * main: Fix incorrect omnibar behavior (#2634) Replase glitch.me pages with privacy-test-pages.site (#2632) BSK update for Autofill Script performance improvements (#2625) Send correct platform value for App Store purchase options (#2633) Collect extra metadata (#2622) Clarified readme "instruments" section (#2607) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1206900948756760/f
Tech Design URL:
CC:
Description:
Greatly reduces the amount of data passed into the autofill script to improve performance and resolve occasional out of memory crashes
Steps to test this PR:
Lightly smoke test autofill functionality to confirm everything still behaves correctly
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template