VPN Domain Exclusions pixel changes #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Aug 15, 2024
| public override func startTunnel(options: [String: NSObject]?, completionHandler: @escaping (Error?) -> Void) { | ||
| super.startTunnel(options: options) { error in | ||
| if error != nil { | ||
| DailyPixel.fireDailyAndCount(pixel: .networkProtectionFailedToStartTunnel, error: error) |
There was a problem hiding this comment.
This pixel is a duplication of networkProtectionTunnelStartFailure and is not needed.
diegoreymendez
commented
Aug 15, 2024
| @@ -32,8 +32,7 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/DuckDuckGo/BrowserServicesKit", | |||
| "state" : { | |||
| "revision" : "c6ce430371032930d770b0388cbe44a2d40ad729", | |||
| "version" : "184.0.0" | |||
| "revision" : "53e333ca0ffcb7da8947c439dfda23f3c0a16336" | |||
There was a problem hiding this comment.
The core reason for this PR is to update BSK to match the latest changes from macOS.
1 task
graeme
approved these changes
Aug 16, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 16, 2024
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f iOS PR: duckduckgo/iOS#3242 macOS PR: duckduckgo/macos-browser#3103 What kind of version bump will this require?: Patch ## Description Adds a domain pixel parameter to PixelKit.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# By Daniel Bernal (4) and others # Via Bartek Waresiak (2) and others * main: (32 commits) Add error pixels for Subscription keychain access errors (#3276) [DuckPlayer] 24. FrontEnd Translation (#3281) [DuckPlayer] 23. Ship Review Fixes (#3279) Logging refactoring phase #2 (#3268) Move WireGuard dependency to packet tunnel provider (#3273) Add PPro unified feedback form (#3248) disable flaky test (#3283) Unified feedback form for Privacy Pro (#3172) Release 7.135.0-1 (#3280) fix back forward swipe gesture in landscape (#3278) Set onboarding completed for sync end to end tests (#3259) Release 7.135.0-0 (#3277) BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275) Fix math expressions on address bar (#3262) fix progress view crash by removing call to flush (#3272) Update autoconsent to v10.15.0 (#3254) Mitigate Onboarding pixels firing with empty atb (#3265) Clean up legacy VPN navigation (#3266) Re-Enable Broken Site Toast on iOS (#3244) Bump BSK (No iOS Changes) (#3261) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 29, 2024
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f BSK PR: duckduckgo/BrowserServicesKit#945 iOS PR: duckduckgo/iOS#3242 Description Adds engagement pixels for VPN domain exclusions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f
BSK PR: duckduckgo/BrowserServicesKit#945
macOS PR: duckduckgo/macos-browser#3103
Description
Removes a duplicated pixel and updates BSK to include the latest macOS changes.
Testing
Really nothing to test here as the BSK changes are only used in macOS right now.
Make sure the CI is green and review the code changes visually.
Internal references:
Software Engineering Expectations
Technical Design Template