VPN Domain Exclusions pixel changes #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Aug 15, 2024
LocalPackages/NetworkProtectionMac/Sources/VPNPixels/DomainExclusionsEngagement.swift
Outdated
Show resolved
Hide resolved
diegoreymendez
commented
Aug 15, 2024
Comment on lines
89
to
90
| let engagementPixel = DomainExclusionsEngagement(exclude: exclude, domain: domain) | ||
| pixelKit?.fire(engagementPixel) |
There was a problem hiding this comment.
We're now tracking engagement
diegoreymendez
commented
Aug 15, 2024
Comment on lines
+41
to
+43
| func scopedPixelName(forUnscopedPixelName unscopedName: String) -> String { | ||
| "\(vpnPixelModulePrefix)_\(unscopedName)" | ||
| } |
There was a problem hiding this comment.
Just a convenience method to add the module prefix to the pixel name.
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 16, 2024
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f iOS PR: duckduckgo/iOS#3242 macOS PR: duckduckgo/macos-browser#3103 What kind of version bump will this require?: Patch ## Description Adds a domain pixel parameter to PixelKit.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# By Dax the Duck (9) and others # Via GitHub (6) and Dominik Kapusta (2) * main: (44 commits) Allow using a production subscription with staging VPN environment (#3109) Add error pixels for Subscription keychain access errors (#3147) onboarding dax dialogs (#3149) Logging refactoring phase #2 (#3154) Move WireGuard dependency to VPN extensions (#3144) Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Fix address bar queries when doing math expressions (#3130) Bump version to 1.103.0 (249) Bump version to 1.103.0 (248) Resolving automatic update edge cases (#3142) PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
samsymons
pushed a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 29, 2024
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f BSK PR: duckduckgo/BrowserServicesKit#945 macOS PR: duckduckgo/macos-browser#3103 Description Removes a duplicated pixel and updates BSK to include the latest macOS changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f
BSK PR: duckduckgo/BrowserServicesKit#945
iOS PR: duckduckgo/iOS#3242
Description
Adds engagement pixels for VPN domain exclusions.
Testing
Test 1: Through the status view
m_mac_vpn_report_site_issuespixel.Test 2: Exclusions through settings
This works like excluding from the status view, but you should never see
m_mac_vpn_domain_exclusion_enabledandm_mac_vpn_domain_exclusion_disabled.The only pixel you should see is the report one (
m_mac_vpn_report_site_issues) if you select to report.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation