Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SwiftLintPlugin to SwiftLintTool #2601

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Convert SwiftLintPlugin to SwiftLintTool #2601

merged 6 commits into from
Apr 18, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Apr 11, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
apple-toolbox PR: duckduckgo/apple-toolbox#3
BSK PR: duckduckgo/BrowserServicesKit#774
iOS PR: duckduckgo/iOS#2710

Description:

  • Removed SwiftLintPlugin from build targets
  • Converted SwiftLintPlugin to a standalone tool leaving the plugin support

Steps to test this PR:

  1. Validate linter is running against all .swift files in a project including ones from other git repo folders
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 11, 2024
@mallexxx mallexxx requested a review from ayoy April 11, 2024 09:41
This was referenced Apr 11, 2024
Merged
Merged
Merged
ayoy
ayoy approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mallexxx I'm approving this but it doesn't work in current shape 😂 see my comment. When I update the statement from != to ==, all works great. Please update and merge. Thanks!

DuckDuckGo.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Apr 18, 2024
@mallexxx
drop SwiftLintPlugin (#774)
7eab61a 
Task/Issue URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
apple-toolbox PR: duckduckgo/apple-toolbox#3
iOS PR: duckduckgo/iOS#2710
macOS PR: duckduckgo/macos-browser#2601
mallexxx added a commit to duckduckgo/apple-toolbox that referenced this pull request Apr 18, 2024
@mallexxx
Implement SwiftLintPlugin as a standalone cli tool (#3)
5cd7f20 
Task URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
BSK PR: duckduckgo/BrowserServicesKit#774
iOS PR: duckduckgo/iOS#2710
macOS PR: duckduckgo/macos-browser#2601
@mallexxx mallexxx mentioned this pull request Apr 18, 2024
Merged
mallexxx added a commit to duckduckgo/apple-toolbox that referenced this pull request Apr 18, 2024
@mallexxx
reimplement XCProject (#4)
4aa8ff7 
Task URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
BSK PR: duckduckgo/BrowserServicesKit#774
iOS PR: duckduckgo/iOS#2710
macOS PR: duckduckgo/macos-browser#2601
@mallexxx mallexxx mentioned this pull request Apr 18, 2024
Merged
mallexxx added a commit to duckduckgo/apple-toolbox that referenced this pull request Apr 18, 2024
@mallexxx
exclude deleted files from linter processing (#5)
ab53ca4 
Task URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
BSK PR: duckduckgo/BrowserServicesKit#774
iOS PR: duckduckgo/iOS#2710
macOS PR: duckduckgo/macos-browser#2601
@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 18, 2024
@mallexxx mallexxx merged commit 73d3543 into main Apr 18, 2024
16 checks passed
@mallexxx mallexxx deleted the alex/swiftlinttool branch April 18, 2024 10:09
mallexxx added a commit to duckduckgo/iOS that referenced this pull request Apr 18, 2024
@mallexxx
Replace SwiftLintPlugin with SwiftLintTool (#2710)
23d089d 
Task/Issue URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
apple-toolbox PR: duckduckgo/apple-toolbox#3
BSK PR: duckduckgo/BrowserServicesKit#774
macOS PR: duckduckgo/macos-browser#2601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@mallexxx mallexxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy